Debugging issue with uploadTidy() not appearing to be called when optional datasetPath argument isn't supplied.

Fork: 0

ONS / pmd-jenkins-library

Browse code Debugging issue with uploadTidy() not appearing to be called when optional datasetPath argument isn't supplied. add_tests master v1.0
1 parent 73d3fba commit cd2d97b621b30f4fd65c1396998a44318bd44c20 Alex Tucker authored on 19 Oct 2018

Patch

Unified Split

Showing 1 changed file

                Ignore Space
               Show notes
              View
            
          
          8 ■■■■■
          vars/uploadTidy.groovy
               def call(csvs, String mapping=null, String datasetPath=util.slugise(env.JOB_NAME)) {
def call(csvs, String mapping=null, String datasetPath=null) {
    if (!datasetPath) {
        datasetPath = util.slugise(env.JOB_NAME)
    }
    configFileProvider([configFile(fileId: 'pmd', variable: 'configfile')]) {
        def config = readJSON(text: readFile(file: configfile))
        String PMD = config['pmd_api']
        String credentials = config['credentials']
+def call(csvs, String mapping=null, String datasetPath=util.slugise(env.JOB_NAME)) {
+def call(csvs, String mapping=null, String datasetPath=null) {
+    if (!datasetPath) {
+        datasetPath = util.slugise(env.JOB_NAME)
+    }
     configFileProvider([configFile(fileId: 'pmd', variable: 'configfile')]) {
         def config = readJSON(text: readFile(file: configfile))
         String PMD = config['pmd_api']
         String credentials = config['credentials']

Show line notes below